Fix --manifest-path to point to Cargo.toml instead of a directory
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `cargo-subcommand` expects this argument to be a path to the directory containing project(s), whereas it should actually point to a file specifically named `Cargo.toml`. Note that this path doesn't appear to be very strict in `cargo`: even if pointing to a manifest file within a workspace, packages in the surrounding workspace are still built, and are reachable through `-p`. However, there's a strict requirement on the specified manifest to be part of the workspace, which is not enforced in `cargo-subcommand` yet.
dvc94ch
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
cargo-subcommandexpects this argument to be a path to the directory containing project(s), whereas it should actually point to a file specifically namedCargo.toml.Note that this path doesn't appear to be very strict in
cargo: even if pointing to a manifest file within a workspace, packages in the surrounding workspace are still built, and are reachable through-p.However, there's a strict requirement on the specified manifest to be part of the workspace, which is not enforced in
cargo-subcommandyet.