ndk: Remove "irrelevant" hardware_buffer/trace feature in favour of API level
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of API level Thus far feature flags have been used specifically in `ndk-sys` to control what native libraries are linked to, for content that is provided outside of the standard linked `libandroid.so`: https://github.com/rust-windowing/android-ndk-rs/blob/d104d01f116b537babdc94d8c9889581f8d63a02/ndk-sys/src/lib.rs#L43-L53 However, `hardware_buffer` and `trace` are available in `libandroid.so` directly making these features only guard our Rust bindings. This is unnecessarily tedious and inconsistent with the rest of the NDK wrappers which are only guarded by their minimum API level.
MarijnS95
force-pushed
the
ndk-remove-unused-features
branch
from
8c9d24a to
b2959d2
Compare
MarijnS95
changed the title
/trace` feature in favour of API levelhardware_buffer/trace feature in favour of API level
This was referenced Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #318
Thus far feature flags have been used specifically in
ndk-systo control what native libraries are linked to, for content that is provided outside of the standard linkedlibandroid.so:https://github.com/rust-windowing/android-ndk-rs/blob/d104d01f116b537babdc94d8c9889581f8d63a02/ndk-sys/src/lib.rs#L43-L53
However,
hardware_bufferandtraceare available inlibandroid.sodirectly making these features only guard our Rust bindings. This is unnecessarily tedious and inconsistent with the rest of the NDK wrappers which are only guarded by their minimum API level.