Lock MSRV to 1.60 and validate in CI #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent inadvertently bumping MSRV in PRs by checking against MSRV in the CI, to disallow any large bumps without rationale. Rust 1.60 is 7 months old at the time of writing, and also required by `winit` which uses `android-ndk-rs`, hence must be compatible with it. This does not mean that we cannot bump MSRV at all, but we must remain a tad conservative; at the same time setting [`rust-version`] in the manifest provides everyone on Rust 1.56 and higher a helpful error message when their version is lower than what we require. [`rust-version`]: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field
Git history suggests that `quick-xml` backed out of an (un?)intentional MSRV bump and is now back at Rust 1.46; well below our MSRV needed for `winit`.
MarijnS95
force-pushed
the
lock-and-validate-msrv
branch
from
69cdeb3 to
54a3d91
Compare
msiglreith
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @kchibisov
Prevent inadvertently bumping MSRV in PRs by checking against MSRV in the CI, to disallow any large bumps without rationale. Rust 1.60 is 7 months old at the time of writing, and also required by
winitwhich usesandroid-ndk-rs, hence must be compatible with it.This does not mean that we cannot bump MSRV at all, but we must remain a tad conservative; at the same time setting
rust-versionin the manifest provides everyone on Rust 1.56 and higher a helpful error message when their version is lower than what we require.