Skip to content

Commit

Permalink
adb: Drop -W (wait for app) from am start for faster --uid filt…
Browse files Browse the repository at this point in the history
…er (#137)

This effectively reverts commit bf478ad
(#118) without touching code improvements elsewhere.  `-W` makes app
start-up significantly slower, sometimes leaving the user wait up to 10
seconds even if the app has already started and crashed without showing
any `logcat` output.  It has now become unnecessary since using the app
`uid` as filter in #131, which is always available as long as the app
is installed and doesn't rely on a running (**before** having crashed!)
executable for a process id.
  • Loading branch information
MarijnS95 authored Sep 14, 2023
1 parent c2f3291 commit 6caae75
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion xbuild/src/devices/adb.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ impl Adb {
.shell(device, None)
.arg("am")
.arg("start")
.arg("-W")
.arg("-a")
.arg("android.intent.action.MAIN")
.arg("-n")
Expand Down

0 comments on commit 6caae75

Please sign in to comment.