Commits on Dec 8, 2022

1. Reject subdirectory manifests that are not members of the workspace …

   The previous implementation had one fatal flaw: having a non-workspace
   `Cargo.toml` in a subdirectory, with a `[workspace]` defined some
   directories higher is invalid when that `[workspace]` doesn't include
   the given `Cargo.toml` subdirectory/package.  `cargo` rejects this with
   a `current package believes it's in a workspace when it's not`, and we
   should do the same instead of having an `unwrap_or_else` that falls back
   to using the workspace root `Cargo.toml` as a package (especially if it
   might not contain a `[package]` at all).
   
   This would for example fail when running `x new template` in the repo
   directory, `cd`'ing into it and invoking `x build`.  Instead of
   complaining about `template/Cargo.toml` not being part of the workspace,
   it detects the workspace and falls back to building the root package
   because the `template` directory appears to just be a subdirectory of
   the root without defining a subpackage along it.  Since our root doesn't
   define a `[package]`, the supposed-to-be-infallible `unwrap()` on
   `manifest.package` below fails.

   

   MarijnS95 committed Dec 8, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for c817b5a
   • Browse repository at this point

   Copy the full SHA

   c817b5a View commit details

   Browse the repository at this point in the history