Add check in blas_compat_1d for stride == 0 and fix for stride < 0 #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. DGEMV doc from http://www.netlib.org/blas/ confirms that INCX must not be zero |
bluss
force-pushed
the
fix-blas_compat_1d-stride0
branch
2 times, most recently
from
7052177 to
48a6024
Compare
|
I think I fixed the other issue too. As usual, BLAS wants the lowest in memory pointer. I'm not sure why we hadn't already fixed this. I added very simple tests to the blas testsuite (the tests would reliably fail and it would reproduce the stride == 0 error message, before the fix). It's relatively fast and easy to run the blas tests. I use |
bluss
changed the title
Stride == 0 is unsuppored for vector increments; Stride < 0 would be supported but the code needs to be adapted to pass the right pointer for this case (lowest in memory pointer). Co-authored-by: bluss <bluss@users.noreply.github.com>
bluss
force-pushed
the
fix-blas_compat_1d-stride0
branch
from
48a6024 to
fe3baa6
Compare
bluss
force-pushed
the
fix-blas_compat_1d-stride0
branch
from
cbd4d45 to
b954a38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1085.
It may also be necessary to return
falsefor negative strides; I haven't tested that.