Revert blas + axpy changes #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @SuperFluffy |
|
Other than the negative and zero stride case, did you find anything that would prevent using blas for non-contiguous but equispaced/compatible arrays? |
|
It should be fine. Equispaced stride doesn't cover one case though, which is F1 + F2 (both arrays are 2+ dimensions, same shape, but in fortran memory order). |
|
Changed to a revert since it broke existing uses of is_contiguous (for negative stride arrays). It's my responsibility to decide on merges, so it's my responsibility there is a bug. |
|
A clearer thought on the situation is that we have two input arrays, and we need to figure out if they are separately blas compatible, but also that they are memory order compatible with each other. Same problem that zip needs to solve. |
bluss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.