Skip to content

Remove trailing whitespace #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

jturner314
Copy link
Member

I realize that this makes git blame harder to use on those lines where I'm removing whitespace, but there aren't many whitespace removals outside of comments and blank lines, so that shouldn't be a big issue.

I'd like to do a mass-reformat once rustfmt is stable, so whitespace removal could wait until then. However, the negative impact of removing the trailing whitespace now is small, and it would be really nice for people like @LukeMathWalker and me who have our editors configured to automatically remove trailing whitespace.

@jturner314 jturner314 requested a review from bluss June 13, 2018 21:50
@bluss
Copy link
Member

bluss commented Jun 14, 2018

Thanks, that's nice. Using rustfmt sounds good.

@bluss bluss merged commit 9afee2c into rust-ndarray:master Jun 14, 2018
@jturner314 jturner314 deleted the rm-trailing-whitespace branch June 14, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants