Adjust constraints on ddof for var_axis and std_axis #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring
ddof
to not be < 0 allows us to ignore weird edge cases. Allowingddof
to be equal to the length of the axis allows computation of the population variance (ddof
= 0) for a zero-length axis and computation of the sample variance (ddof
= 1) for an axis of length one. (The result in these cases is an array of NaNs.)Note that this is a breaking change because of the new constraint that
ddof
must not be less than zero.