Feature/add nip 58 support in eventbuilder

[0xtrr]

Description

This PR adds convenience functions to the EventBuilder for creating a new badge and awarding a badge to a set of pubkeys.

Notes to the reviewers

I'd love to get a second look at the functions to verify that it makes sense as is.

I didn't add a function for setting profile badges (the last operation in NIP-58) because I simply couldn't figure out a good way to structure the function inputs so that we ensure a consecutive order in the a and e tags.

Changelog notice

# Added
- EventBuilder for defining a badge
- EventBuilder for awarding a badge

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran make precommit before committing

[yukibtc]

Thanks!

Have you checked the nip58 module?

Probably it can be possible to move some things, like BadgeDefinitionBuilder, in EventBuilder (remove BadgeDefinitionBuilder and use your define_badge method).

If you have not time, let me know that I'll try to merge these two implementations of nip58.

[0xtrr]

Thanks!

Have you checked the nip58 module?

Probably it can be possible to move some things, like BadgeDefinitionBuilder, in EventBuilder (remove BadgeDefinitionBuilder and use your define_badge method).

If you have not time, let me know that I'll try to merge these two implementations of nip58.

Ohh lol, forgot to theck the nip modules. I'll close this PR then as the nip58 module contains what I need and seems like a much better overall implementation!

[0xtrr]

Probably it can be possible to move some things, like BadgeDefinitionBuilder, in EventBuilder (remove BadgeDefinitionBuilder and use your define_badge method).

Well.. maybe that's not a bad idea. The structs specifically related to the NIP will belong inside the module, then we can expose a builder of such event in the event builder. I think that makes more sense, but I'm not sure what you intend the NIP modules to be. Do you want each NIP-specific module to take care of everything related to that specific NIP (i.e. data structures as well as building the events) or should they contain related datastructures and operations only and then building the event can be exposed through the EventBuilder interface?

[yukibtc]

Until now the event composition was done with EventBuilder. Everything else related to the NIP is inside the dedicated nipXX module.

The only one struct that build an event outside the event::builder module, seems to be the BadgeDefinitionBuilder.
I prefer to keep the code organized in the same way for all modules, so in this case we can:
A) move the BadgeDefinitionBuilder code and inside a method in EventBuilder
B) keep the BadgeDefinitionBuilder but do the same for other NIPs (the EventBuiler will be like a "proxy")

If we opt for Option B, I think that BadgeDefinitionBuilder should return the EventBuilder instead of the Event.

[0xtrr]

I'd vote for option A as that makes the most sense for me. I can refactor this PR to fit option A, then you can see if you like it or not.

[yukibtc]

Let me know when the PR is ready to be reviewed

[0xtrr]

Let me know when the PR is ready to be reviewed

I will! I'm implementing this in nostr-tool to verify that it works as expected but I'm currently having some problems with the get_events_of() function where I always get 0 events back when querying for the badge definition event I created. Need some more time to figure out why that happens.

[0xtrr]

This PR is ready for review @yukibtc. I want to say that I'm not an Rust expert(still learning) and these changes are fairly technical for me so please take a good look over the code to ensure that I'm not introducing any newbie mistakes here. The code in the event builder is mostly from the old nip58 functions.

Example implementation can be found in this PR: 0xtrr/nostr-tool#54

[yukibtc]

Before merge, can you squash the commits together?
So will remain a single commit, like: "nostr: add NIP58 support in EventBuilder"

[0xtrr]

Before merge, can you squash the commits together? So will remain a single commit, like: "nostr: add NIP58 support in EventBuilder"

Done

[yukibtc]

utACK cf531e7