Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add httpdata struct to get http auth information from tags in event #143

Merged
merged 1 commit into from
Jul 28, 2023
Merged

add httpdata struct to get http auth information from tags in event #143

merged 1 commit into from
Jul 28, 2023

Conversation

w3irdrobot
Copy link
Contributor

Description

Commit ab36259 added the Kind and Tags to be used for NIP98 events. NIP98 tags contain some metadata that would be great to have easy access to in a struct that knows how to parse the tags and get that information, much like is done with NIP94 FileMetadata. This PR adds an HttpData struct that does just this. This makes it easy to get the necessary data from the tags and also get the tags from the data struct.

Changelog notice

Added HttpData struct for interacting with NIP98 HTTP data

Checklists

All Submissions:

@yukibtc
Copy link
Member

yukibtc commented Jul 27, 2023

Thanks, is this PR ready?

@w3irdrobot
Copy link
Contributor Author

should be, unless you'd like me to add some tests

Copy link
Member

@yukibtc yukibtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a973568

@yukibtc yukibtc merged commit 7a36bb1 into rust-nostr:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants