Updates to remaining NWC extensions #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
nwc-extensions
branch
5 times, most recently
from
0f44701 to
8f364b3
Compare
benthecarman
force-pushed
the
nwc-extensions
branch
2 times, most recently
from
1831bec to
87a9b2f
Compare
|
Looks like CI failure is unrelated to this |
Yes, it's related to MSRV. I'm try to fixing it |
benthecarman
force-pushed
the
nwc-extensions
branch
2 times, most recently
from
2ac554b to
610330d
Compare
benthecarman
force-pushed
the
nwc-extensions
branch
from
610330d to
76e81f5
Compare
|
Extension PR is stabilized at this point, not going to do any more large changes |
|
Spec is merged 🚀 nostr-protocol/nips#685 |
yukibtc
requested changes
Jan 26, 2024
benthecarman
force-pushed
the
nwc-extensions
branch
from
76e81f5 to
f95ced1
Compare
|
Thanks! Fixed |
yukibtc
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the NWC functionality to be up-to-date with the updates made in nostr-protocol/nips#685
Notes to the reviewers
~Probably should wait for the spec to be merged, jumped the gun on the last one: ~
nostr-protocol/nips#685Merged and ready for review!
Changelog notice
Updates NWC commands to latest version