Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js(nostr): complete EventBuilder #266

Merged
merged 18 commits into from
Mar 13, 2024
Merged

js(nostr): complete EventBuilder #266

merged 18 commits into from
Mar 13, 2024

Conversation

rustedmoon
Copy link
Contributor

@rustedmoon rustedmoon commented Jan 28, 2024 •
edited
Loading

Description

Complete EventBulder with missing constructor

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@yukibtc yukibtc changed the title js(nostr), complete EventBuilder js(nostr): complete EventBuilder Jan 29, 2024
@rustedmoon rustedmoon force-pushed the javascript-bindings-builder branch 2 times, most recently from e991ed3 to 5688fa7 Compare March 7, 2024 10:16
@rustedmoon rustedmoon marked this pull request as ready for review March 7, 2024 14:51
@yukibtc yukibtc added this to the Release v0.29 milestone Mar 7, 2024
@yukibtc
Copy link
Member

yukibtc commented Mar 11, 2024

@rustedmoon Can you rebase?

@rustedmoon
Copy link
Contributor Author

@rustedmoon Can you rebase?

Done

yukibtc
yukibtc requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@yukibtc yukibtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are some things to adjust/fix.

I noticed some issues with the CI. Now should be fixed in master branch (make a rebase before commit fixes)

bindings/nostr-js/src/event/tag.rs Outdated Show resolved Hide resolved
bindings/nostr-js/src/nips/nip15.rs Show resolved Hide resolved
bindings/nostr-js/src/nips/nip15.rs Show resolved Hide resolved
bindings/nostr-js/src/nips/nip53.rs Outdated Show resolved Hide resolved
bindings/nostr-js/src/nips/nip53.rs Outdated Show resolved Hide resolved
bindings/nostr-js/src/nips/nip53.rs Outdated Show resolved Hide resolved
@rustedmoon
js(nostr): add EventBuilder::long_form_text_note
5eefdde
@rustedmoon
js(nostr): add EventBuilder::report
220437d
@rustedmoon
js(nostr): add EventBuilder::public_zap_request
db0236b
@rustedmoon
js(nostr): add EventBuilder::zap_receipt
b0923e8
@rustedmoon
js(nostr): add EventBuilder::relay_list
5bf572f
@rustedmoon
js(nostr): add EventBuilder::define_badge
6071a4f
@rustedmoon
js(nostr): add EventBuilder::award_badge
90c5eed
@rustedmoon
js(nostr): add EventBuilder::profile_badges
bb33a6e
@rustedmoon
js(nostr): add EventBuilder::job_request
82622ad
@rustedmoon
js(nostr): add EventBuilder::job_result
6f7f33b
@rustedmoon
js(nostr): add EventBuilder::job_feedback
3ee64a1
@rustedmoon
js(nostr): add EventBuilder::file_metadata
4ece12f
@rustedmoon
js(nostr): add EventBuilder::http_auth
edd3513
@rustedmoon
js(nostr): add EventBuilder::stall_data
1e55287
@rustedmoon
js(nostr): add EventBuilder::product_data
f887941
@rustedmoon
js(nostr): add EventBuilder::live_event
2d40b80
@rustedmoon
js(nostr): add EventBuilder::live_event_msg
d07c06e
@rustedmoon rustedmoon force-pushed the javascript-bindings-builder branch 2 times, most recently from 50c8255 to 89179d8 Compare March 13, 2024 14:28
@rustedmoon
js(nostr): some adjustment to EventBuilder and related things
3e15486 
- add missing `#[wasm_bindgen(constructor)]`
- add missing `new` constructor
- fix clippy
yukibtc
yukibtc approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@yukibtc yukibtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3e15486

@yukibtc yukibtc merged commit 62e6b0b into rust-nostr:master Mar 13, 2024
6 checks passed
@rustedmoon rustedmoon deleted the javascript-bindings-builder branch March 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukibtc yukibtc yukibtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v0.29
Development

Successfully merging this pull request may close these issues.
2 participants
@rustedmoon @yukibtc