Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book:just configs #661

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

RandyMcMillan
Copy link
Contributor

No description provided.

@RandyMcMillan
Copy link
Contributor Author

book:clean install and serve in 1 minute

nostr-rs-book.480.mov

@RandyMcMillan RandyMcMillan force-pushed the 1985/872668/752821/358b43c0/d33a7b48-book-just-configs branch from 7b05485 to 310d537 Compare November 30, 2024 21:14
@RandyMcMillan RandyMcMillan force-pushed the 1985/872668/752821/358b43c0/d33a7b48-book-just-configs branch from 310d537 to cd03183 Compare November 30, 2024 21:30
Comment on lines +31 to +34
rm -rf $(which mdbook)
rm -rf $(which mdbook-linkcheck)
rm -rf $(which mdbook-admonish)
rm -rf $(which mdbook-snippets)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I would use cargo uninstall, so will work on every OS.

Comment on lines +11 to +12
nostr-sdk = { version = "*", features = ["all-nips"] }
nostr-relay-builder = "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version here must match the version in the book docs, so 0.37.

@@ -64,7 +68,7 @@ clean:

# Build and serve the book
book:
cd book && just serve
cd book && just build serve
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to call build command when serving. The book is automatically built when running mdbook serve.

Comment on lines +48 to +51
# Build nostr examples
examples:
cargo build --examples --release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that who want to run an example, build and run only the one is interested in, so this command IMO is not really needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants