-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add divide-by-zero panic messages #144
Conversation
I hope I targeted the right branch, by the way. I was using the version on cargo, v0.2.6, when I noticed the lack of panic messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this cleanup!
The master branch is good -- I hope to wrap up 0.3 "soon". 🤞 I've made a few bugfixes on 0.2 in the meantime, but I don't think I'd bother just for a diagnostic. |
I did these changes from the GitHub editor, which is why there are so many commits. I assume you squash and merge anyway? |
I use a bot that does a plain merge, without squashing. I prefer to allow that PRs may have a series of meaningful commits, but in this case the separate commits are not helpful. So it would be great if you could squash this branch, or I can quickly do so myself. |
It'd be easier for you to do it, please. Thank you. |
This brings it more in line with std's numbers, and lets the user actually know why it panicked.
Thanks again! bors r+ |
Build succeeded: |
This brings it more in line with std's numbers, and lets the user actually know why it panicked.