Implement is_one and Inv for Complex. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be good with a bump to num-traits 0.2.1. |
cuviper
reviewed
Mar 1, 2018
src/lib.rs
Outdated
| @@ -664,6 +664,24 @@ impl<'a, T: Clone + Num + Neg<Output = T>> Neg for &'a Complex<T> { | |||
| } | |||
| } | |||
|
|
|||
| impl<T: Clone + Num + Inv<Output = T>> Inv for Complex<T> { | |||
There was a problem hiding this comment.
I don't think we need T: Inv, but we do need T: Neg for the inherent fn inv.
cuviper
reviewed
Mar 1, 2018
|
|
||
| #[inline] | ||
| fn inv(self) -> Complex<T> { | ||
| self.inv() |
There was a problem hiding this comment.
I'm not sure, but you might have to make this explicitly (&self).inv() to avoid recursion.
clarfonthey
changed the title
|
Should be working now |
|
I repeat, now it should be working. |
|
Thanks! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a new version of
num-traitsto be pushed.