-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serde-1.0 #7
serde-1.0 #7
Conversation
Ah, yes, I forgot to open issues for this. We did it before in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update the CI scripts, updating the min to 1.13 (if we don't use derive) and removing the part that tests a downgrade to serde-0.7.
Cargo.toml
Outdated
|
||
[features] | ||
default = ["rustc-serialize"] | ||
default = ["serde"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this to be in the default features.
src/lib.rs
Outdated
Ok(Complex::new(re, im)) | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to keep the same manual impl
, just updated for the newer API.
I've fix using
|
Great, thanks! I may tweak that minimum version, but it's fine for now. I'm not sure when I'll be ready to start merging changes for 0.2, but I'll use this PR when I do. |
We'll probably have rand to test soon too.
Rebased -- thanks again! bors r+ |
Build succeeded |
serde-1.0 should be the default serialization option since rustc-serialize is already obsolete.
Note: This is a breaking change. We need to bump up the version to 0.2.