Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump proc macros 2 module to latest version #13

Closed
tirkarthi opened this issue May 22, 2018 · 2 comments
Closed

Bump proc macros 2 module to latest version #13

tirkarthi opened this issue May 22, 2018 · 2 comments

Comments

@tirkarthi
Copy link

tirkarthi commented May 22, 2018

Bug report :

There was a recent change in proc macros 1.2 API that made some breaking changes. It broke proc macros 2 with version 0.3.8 on some projects. So I tried running this project against latest nightly and it works which should have caused an error during compilation of proc macros 2 module.

Upstream rustc issue reference : rust-lang/rust#50473 (comment)
Upstream proc macros 2 PR (merged) : dtolnay/proc-macro2#90
Successful Nightly build with 0.3.8 compilation : https://travis-ci.org/tirkarthi/num-derive/jobs/382026352

Failure of proc macros 0.3.8 compilation in Rocket : https://travis-ci.org/SergioBenitez/Rocket/jobs/381529609#L527
proc macros 2 v0.4.3 released with the changes. Ref : https://github.com/alexcrichton/proc-macro2/tree/0.4.3

Feel free to close this if it's irrelevant or I am missing something.

Thanks

@cuviper
Copy link
Member

cuviper commented May 22, 2018

I suspect those changes are only a problem if you enable nightly/unstable features in proc-macro2. Since we don't do that here, it's still building fine. Regardless, I'll look into updating syn/quote/proc-macro2 to their latest releases.

bors bot added a commit that referenced this issue May 22, 2018
14: Update macro dependencies r=cuviper a=cuviper

Closes #13.

Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors bors bot closed this as completed in #14 May 22, 2018
@cuviper
Copy link
Member

cuviper commented May 22, 2018

num-derive 0.2.2 is published with updated dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants