Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add std feature to Cargo manifest #21

Closed
wants to merge 1 commit into from

Conversation

Richard-W
Copy link

This enables use of this crate in environments where std is not
available.

This enables use of this crate in environments where std is not
available.
@cuviper
Copy link
Member

cuviper commented Jan 17, 2019

My first reaction is that this shouldn't matter, because proc-macros always have std available regardless of actual target. But I suspect you're encountering rust-lang/cargo#2589, where the features of build-deps end up forcing the feature in target deps too.

To be honest, I don't remember why I made that a direct dependency at all. I moved it as part of the doctest commit in #11, but it seems to work fine as just a dev-dep, which should solve your issue too.

@Richard-W
Copy link
Author

Richard-W commented Jan 19, 2019

So do you suggest moving the num-traits dep in num-derive to dev-dependencies or do you suggest that my project moves num-derive?

In the latter case this pull request can be closed.

@cuviper
Copy link
Member

cuviper commented Jan 20, 2019

I'm suggesting to change it here.

@cuviper
Copy link
Member

cuviper commented Jan 26, 2019

I made the change in #22, including a CI test using thumb as a no-std target. This is published as 0.2.4. Please let me know if you have any more trouble with no-std!

@cuviper cuviper closed this Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants