Disable functions for i128 if not supported. #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
reviewed
Apr 13, 2021
There was a problem hiding this comment.
I don't think this is the right change -- please see #46 (comment).
| @@ -283,6 +283,7 @@ pub fn from_primitive(input: TokenStream) -> TokenStream { | |||
| <#inner_ty as #import::FromPrimitive>::from_i32(n).map(#name) | |||
| } | |||
| #[inline] | |||
| #[cfg(has_i128)] | |||
There was a problem hiding this comment.
This cfg is being emitted into the user's code, so I think it will effectively block all i128 unless they happen to have set has_i128 in the target crate.
|
Closing as the correct solution should probably be in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For targets that don't support
i128andu128, disable functions that require them in theFromPrimitiveandToPrimitivetraits. This is consistent with the num-traits crate which does not require these for targets that don't support them. Fixes #46.