Fix #49 #51
Merged
Fix #49 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbla
commented
Jun 20, 2019
It's effectively performing Euclid's algorithm, so its runtime is O(n) assuming all operations take constant time (so more than that for Edit: O(n) where n is the number of bits in the smaller of the two denominators.
FYI I'm pretty sure you're right that we can't, we'd need specialization (or, as you mention, negative traits, but these seem even less likely to land soon). The changes in the CR look good to me but I'm not a member so that's not worth much :p |
cuviper
reviewed
Jul 17, 2019
Co-Authored-By: Josh Stone <cuviper@gmail.com>
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 18, 2019
51: Fix #49 r=cuviper a=maxbla fixed issue #49 added a test case for it Side note: `cmp` is a bit scary. Do we know what it's amortized runtime is? It seems to me that the worst case (having to compare the reciprocals many times) could be pretty bad. Is there any way to have a separate `impl` for `T: Clone + Integer + CheckedMul`? As the comments note, CheckedMul would make the implementation faster. I messed around, but I can't find a way to have two implementations -- one for checked and one for no checked. I found an [this](rust-lang/rfcs#586) RFC for negative trait bounds though (spoiler: negative trait bounds are not happening soon). Co-authored-by: Max Blachman <blachmanmax@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issue #49
added a test case for it
Side note:
cmpis a bit scary. Do we know what it's amortized runtime is? It seems to me that the worst case (having to compare the reciprocals many times) could be pretty bad. Is there any way to have a separateimplforT: Clone + Integer + CheckedMul? As the comments note, CheckedMul would make the implementation faster. I messed around, but I can't find a way to have two implementations -- one for checked and one for no checked. I found an this RFC for negative trait bounds though (spoiler: negative trait bounds are not happening soon).