Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Remove Copy bound from Real #245

Open
CraftSpider opened this issue Aug 13, 2022 · 1 comment
Open

[feature request] Remove Copy bound from Real #245

CraftSpider opened this issue Aug 13, 2022 · 1 comment
Labels
breaking change

Comments

@CraftSpider
Copy link

Basically the reverse request of #243 - Currently, Real implies Copy, which restricts it from being implemented for real-value types that use non-copy internals (for example, a type that represents values as whole fractions backed by a BigInt). The Copy bound doesn't seem to be actually useful to the trait, and more like a holdover from when it was split out from Float.

This would be a breaking change unfortunately.
@CraftSpider
Copy link
Author

Just an added thought - If this change is made, it may be a good time to add Bounded as a super-trait and remove the min_value and max_value methods, as they're documented to do the same things

@LucaCiucci LucaCiucci mentioned this issue Aug 18, 2023
Open
LucaCiucci added a commit to LucaCiucci/num-traits that referenced this issue Aug 18, 2023
@LucaCiucci
Remove the Copy trait
3a538b0 
Relevan issue: rust-num#245
@LucaCiucci LucaCiucci mentioned this issue Aug 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuviper @CraftSpider