Added copysign fixes #152 #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
changed the title
|
Please look at the failed CI results, and let me know if you need help... |
tspiteri
reviewed
Jul 22, 2020
Comment on lines
+1832
to
+1834
| if self.is_nan() { | ||
| sign / Self::zero() | ||
| } else if self.signum() == sign.signum() { |
There was a problem hiding this comment.
is_sign_negative is better than signum here as it works on NaNs as well; signum itself is implemented using is_sign_negative in the trait.
Then the special case for NaN can be removed as both is_sign_negative and neg work well on NaNs. (Currently the NaN special case is buggy anyway and returns infinity rather than NaN.)
|
@peartt Hello, are you still interested in continuing this PR? 🙂 As I would be interested in seeing this merged so we can use it in a project, and would be willing to continue the work. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.