Add f16, f128 #333
Open
Add f16, f128 #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
reviewed
Aug 26, 2024
src/lib.rs
Outdated
Comment on lines
20
to
21
| #![cfg_attr(feature = "f16", feature(f16))] | ||
| #![cfg_attr(feature = "f128", feature(f128))] |
There was a problem hiding this comment.
I'm not keen on maintaining for unstable features in this crate, so we're probably going to be blocked here until the language and standard library stabilize these new floats.
At that point, I think we'll probably want to have detection in the build script to enable it automatically, and Cargo features can force that on -- like we used to for has_i128.
usamoi
force-pushed
the
master
branch
2 times, most recently
from
c6e7689 to
dc38e4d
Compare
cuviper
reviewed
Aug 31, 2024
usamoi
force-pushed
the
master
branch
2 times, most recently
from
70e6d69 to
510dfa4
Compare
92 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integer_decodeis implemented forf128by truncating the radix to its 64 most significant bits. See Float::integer_decode cannot be implemented for quadruple precision floating types. #98.f128tests underno_stdandlibmfail.