Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure when using num_derive on latest nightly #240

Closed
est31 opened this issue Nov 16, 2016 · 3 comments
Closed

Failure when using num_derive on latest nightly #240

est31 opened this issue Nov 16, 2016 · 3 comments
Assignees
@hauleth

Comments

@est31
Copy link
Contributor

est31 commented Nov 16, 2016

To reproduce, run cargo test on the num/derive subdir, you will get lots of "a type named ... has already been defined in this module".

I can reproduce with 1.15.0-nightly (0ed951993 2016-11-14).

This change in behaviour was probably caused by rust-lang/rust#37614, but its actually wanted behaviour.

Basically the proc macro isn't expected anymore to output the item itself, only the impl's.
@hauleth
Copy link
Member

hauleth commented Nov 16, 2016

Will investigate.

@hauleth hauleth self-assigned this Nov 16, 2016
@est31
Copy link
Contributor Author

est31 commented Nov 27, 2016

@hauleth any news?

hauleth added a commit that referenced this issue Nov 27, 2016
@hauleth
fix(num_derive): code duplication error
20243f5 
Fixes #240
@hauleth hauleth mentioned this issue Nov 27, 2016
Merged
@hauleth
Copy link
Member

hauleth commented Nov 27, 2016

@est31 #242

est31 added a commit to est31/rust-media that referenced this issue Jan 28, 2017
@est31
Update num-derive to work with latest rustc
a9f7069 
See rust-num/num#240
remexre pushed a commit to remexre/num that referenced this issue Jun 1, 2017
@dtolnay
Merge pull request rust-num#240 from Kroisse/from-iterator-for-map
9984a31 
Implement FromIterator and Extend for value::Map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hauleth hauleth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hauleth @est31