bigint: add From implementations #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather see those benchmarks as simple tests, so they're verified on all targets. Benchmarks only work on nightlies. (It's also not very interesting code performance-wise, spending most of its time in the heap allocator for the data Vec.) Otherwise, the implementation looks great! |
From all primative unsigned ints to BigUint From all primative ints to BigInt From BigUint to BigInt Closes: rust-num#117
|
I've removed the benchmarks and added some tests. |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Dec 13, 2015
bigint: add From implementations From all primative unsigned ints to BigUint From all primative ints to BigInt From BigUint to BigInt Closes: #117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From all primative unsigned ints to BigUint
From all primative ints to BigInt
From BigUint to BigInt
Closes: #117