Make rand and rustc-serialize dependencies optional.
#154
Conversation
Previously, the `rand` and `rustc-serialize` dependencies were optional except they were required for the `bigint` feature. Make the dependency on the `rand` crate optional in all cases. including when the `bigint` feature is selected. Some of the tests for the bigint feature are randomized so, while `rand` is now an optional dependency, it is a non-optional dev-dependency. Similarly, make the dependency on the `rustc-serialize` crate optional in all cases, including when the `bigint` feature is selected.
|
The Nightly build fails because of rust-lang/rust#30713, which should be fixed in the next Rust Nightly. With this commit, packages depending on |
|
I think this is good. My only concern is that someone using just feature bigint will now lose functionality, so that's a breaking change. But since this isn't the default case, I'm leaning toward accepting that. What do you think @hauleth? |
|
I don't see how one could loose functionality by using only |
Make `rand` and `rustc-serialize` dependencies optional. Previously, the `rand` and `rustc-serialize` dependencies were optional except they were required for the `bigint` feature. Make the dependency on the `rand` crate optional in all cases. including when the `bigint` feature is selected. Some of the tests for the bigint feature are randomized so, while `rand` is now an optional dependency, it is a non-optional dev-dependency. Similarly, make the dependency on the `rustc-serialize` crate optional in all cases, including when the `bigint` feature is selected.
|
💔 Test failed - status |
|
Grr, still no new published nightly to fix rand. |
Make `rand` and `rustc-serialize` dependencies optional.
|
Yeah, I am also waiting for that fix. Today should be new nightly build. It is strange. Łukasz Jan Niemier Dnia 8 sty 2016 o godz. 18:52 Josh Stone notifications@github.com napisał(a):
|
Previously, the
randandrustc-serializedependencies were optionalexcept they were required for the
bigintfeature.Make the dependency on the
randcrate optional in all cases.including when the
bigintfeature is selected. Some of the tests forthe bigint feature are randomized so, while
randis now an optionaldependency, it is a non-optional dev-dependency.
Similarly, make the dependency on the
rustc-serializecrate optionalin all cases, including when the
bigintfeature is selected.