bigint: Fix calculation of size for multiply temporaries #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Can you add the test that failed #187?
|
When x.len() and y.len() are both equal and odd, we have x1.len() + y1.len() + 1 (the required size to multiply x1 and y1) > y.len() + 1 This fixes rust-num#187
|
Done |
homu
added a commit
that referenced
this pull request
Apr 20, 2016
bigint: Fix calculation of size for multiply temporaries When x.len() and y.len() are both equal and odd, we have x1.len() + y1.len() + 1 (the required size to multiply x1 and y1) > y.len() + 1 This fixes #187
|
⚡ Test exempted - status |
remexre
pushed a commit
to remexre/num
that referenced
this pull request
Jun 1, 2017
Extract serde_json::Map and serde_json::Number opaque newtypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When x.len() and y.len() are both equal and odd, we have x1.len() + y1.len() + 1
(the required size to multiply x1 and y1) > y.len() + 1
This fixes #187