traits: add to_degrees and to_radians on Float
#212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid a breaking change, these have crude default implementations as well as better implementations for `f32` and `f64` in particular. They don't use the inherent methods though, because `f32` didn't stabilize those until Rust 1.7. Fixes rust-num#211
|
Looks great, thanks! 🎊 |
|
@homu r+ |
|
📌 Commit 0faeb31 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jul 24, 2016
traits: add `to_degrees` and `to_radians` on `Float` To avoid a breaking change, these have crude default implementations as well as better implementations for `f32` and `f64` in particular. They don't use the inherent methods though, because `f32` didn't stabilize those until Rust 1.7. Fixes #211
|
@cuviper Great! Any chance a new release could get cut? |
|
Sure - I just published num-traits-0.1.34. |
|
Thanks a ton! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a breaking change, these have crude default implementations as
well as better implementations for
f32andf64in particular. Theydon't use the inherent methods though, because
f32didn't stabilizethose until Rust 1.7.
Fixes #211