Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix num-macros for nightly #229

Merged
merged 1 commit into from
Sep 18, 2016
Merged

Fix num-macros for nightly #229

merged 1 commit into from
Sep 18, 2016

Conversation

bluss
Copy link
Contributor

@bluss bluss commented Sep 18, 2016

Now compatible with rustc 1.13.0-nightly (32571c05c 2016-09-17)

Now compatible with rustc 1.13.0-nightly (32571c05c 2016-09-17)
@bluss
Copy link
Contributor Author

bluss commented Sep 18, 2016

Syntax extension breaks are usually super simple things like this. For now it's sensible to just not support deriving on unions (it would be a new feature, not suitable for a fix PR).

@hauleth
Copy link
Member

hauleth commented Sep 18, 2016

I was just working on that. But thanks 👍

@hauleth
Copy link
Member

hauleth commented Sep 18, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Sep 18, 2016

📌 Commit 6cfd6c8 has been approved by hauleth

@homu homu merged commit 6cfd6c8 into rust-num:master Sep 18, 2016
homu added a commit that referenced this pull request Sep 18, 2016
Fix num-macros for nightly

Now compatible with rustc 1.13.0-nightly (32571c05c 2016-09-17)
@homu
Copy link
Contributor

homu commented Sep 18, 2016

⚡ Test exempted - status

@bluss bluss deleted the fix-macros branch September 18, 2016 20:41
@bluss
Copy link
Contributor Author

bluss commented Sep 18, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants