docs.rs build fails

[lovasoa]

docs.rs does not have internet access when building crates. It errors with

[INFO] running `Command { std: "docker" "start" "-a" "e88f3d05b62cfa58540ddfa084030b80a985615d6d0344498460d819d09e2528", kill_on_drop: false }`
[INFO] [stderr] warning: target filter specified, but no targets matched; this is a no-op
[INFO] [stderr]    Compiling scip-sys v0.1.17
[INFO] [stderr]    Compiling highs-sys v1.6.4
[INFO] [stderr]     Checking fnv v1.0.7
[INFO] [stderr] warning: scip-sys@0.1.17: Detected OS: linux
[INFO] [stderr] warning: scip-sys@0.1.17: Detected arch: x86_64
[INFO] [stderr] warning: scip-sys@0.1.17: Downloading from https://github.com/scipopt/scipoptsuite-deploy/releases/download/v0.6.1/libscip-linux.zip
[INFO] [stderr] error: failed to run custom build command for `scip-sys v0.1.17`
[INFO] [stderr] 
[INFO] [stderr] Caused by:
[INFO] [stderr]   process didn't exit successfully: `/opt/rustwide/target/debug/build/scip-sys-df91aee050761f5b/build-script-build` (exit status: 101)
[INFO] [stderr]   --- stdout
[INFO] [stderr]   cargo:warning=Detected OS: linux
[INFO] [stderr]   cargo:warning=Detected arch: x86_64
[INFO] [stderr]   cargo:warning=Downloading from https://github.com/scipopt/scipoptsuite-deploy/releases/download/v0.6.1/libscip-linux.zip
[INFO] [stderr] 
[INFO] [stderr]   --- stderr
[INFO] [stderr]   thread 'main' panicked at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/scip-sys-0.1.17/bundled.rs:44:29:
[INFO] [stderr]   Failed to download and extract SCIP: https://github.com/scipopt/scipoptsuite-deploy/releases/download/v0.6.1/libscip-linux.zip: Dns Failed: resolve dns name 'github.com:443': failed to lookup address information: Temporary failure in name resolution
[INFO] [stderr]   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] running `Command { std: "docker" "inspect" "e88f3d05b62cfa58540ddfa084030b80a985615d6d0344498460d819d09e2528", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e88f3d05b62cfa58540ddfa084030b80a985615d6d0344498460d819d09e2528", kill_on_drop: false }`
[INFO] [stdout] e88f3d05b62cfa58540ddfa084030b80a985615d6d0344498460d819d09e2528

https://docs.rs/crate/good_lp/1.11.0/builds/1603664

I think the regression was introduced by #72

@KnorpelSenf, could you please look into it ?

We can either set a different default set of solvers (to compile scip as we did before) or introduce conditional compilation on docsrs

[KnorpelSenf]

I can look into it next week, I'm currently on vacation. Adding back the build setup would leave us with two setups that might deviate or silently break, right? So conditional compilation is better?

[lovasoa]

Well, anyway there is going to be a different setup on ci and on docsrs, so one of them may silently break...

[KnorpelSenf]

Fair enough