-
Notifications
You must be signed in to change notification settings - Fork 67
Pad boot image to block size #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot! Looks good to me overall. One small nit: Could you rename the first |
@phil-opp Done. I also formatted the changes as suggested by |
Thanks! bors r+ |
Canceled |
@phil-opp Whoops, looks like I shouldn't have formatted the code further. |
bors r+ |
bors r- I think we can merge this manually (pending the CI checks). |
Canceled |
Seems like the test failed on Windows:
|
@phil-opp Any idea what the problem could be? |
Finally passes all checks! I found a comment which seems related:
I guess that whatever API is used internally by Rust for |
Thanks for investigating! Let's get this merged! |
Thanks a lot for tackling this! I will publish a new version tomorrow when I'm at my computer again. |
@phil-opp Cool, that will be great. |
Released as version 0.7.4. |
Closes #35.