Don't exit with expected exit code when failed to read QEMU exit code #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
force-pushed
the
fix-error-code
branch
from
e12a487
to
3fb8a4d
Compare
bjorn3
approved these changes
Nov 2, 2019
phil-opp
force-pushed
the
fix-error-code
branch
2 times, most recently
from
6ed8021
to
fc43139
Compare
bjorn3
suggested changes
Nov 2, 2019
| eprintln!("QEMU process was terminated by signal {}", signal); | ||
| } | ||
| } | ||
| let qemu_exit_code = exit_status.code().ok_or("Failed to read QEMU exit code")?; |
There was a problem hiding this comment.
This should not say Failed to read QEMU exit code when there was a signal.
There was a problem hiding this comment.
I'm not sure. The cause for the error still is that there is no exit code, so I think it makes sense to print it.
phil-opp
force-pushed
the
fix-error-code
branch
from
fc43139
to
8f42572
Compare
phil-opp
added a commit
that referenced
this pull request
Nov 20, 2019
|
Published as version 0.7.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If failed to read the QEMU exit code, bootimage exits with the expected exit code specified in the
test-success-exit-codeconfig key. Instead, it should report an error when failing to read the QEMU exit code and never exit with the expected exit code.Reported in phil-opp/blog_os#591 (comment)
Thanks to @Jos-B and @bjorn3 for reporting and helping with debugging!