Change register used in setting SS in stage_4 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the register used when setting the stack segment in stage_4 from bx to ax. The register bx is reserved by LLVM.
|
Thanks for the pull request! I just restarted our CI job in order to test it with the latest nightly and I can confirm that the mentioned error occurs. It looks like it is caused by rust-lang/rust#84658. So apparently using |
phil-opp
added a commit
that referenced
this pull request
May 5, 2021
|
Published as v0.10.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The register
bxis apparently reserved by LLVM, and building with the latest nightly (1.54-nightly) fails because of it:This pull request changes the register used to
ax.I don't think this'll be able to break anything.
cargo testpasses, and building and running my own kernel works.