Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relocation-model field name in the target spec json #186

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Fix relocation-model field name in the target spec json #186

merged 1 commit into from
Aug 9, 2021

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Jul 17, 2021

cc #185

@bjorn3 bjorn3 mentioned this pull request Jul 17, 2021
Merged
josephlr
josephlr approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@josephlr josephlr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't have merge permissions for this repo (I think only @phil-opp does?).

EDIT: this fixes any warnings on current nightly.

@phil-opp
Copy link
Member

phil-opp commented Aug 9, 2021

Thanks and sorry for the delay!

As mentioned in #185, this effectively changes the relocation model from pic to static, so we should keep our eyes open for possible bugs or other side effects.

@phil-opp phil-opp merged commit aeb44a1 into rust-osdev:main Aug 9, 2021
phil-opp added a commit that referenced this pull request Aug 9, 2021
@phil-opp
Update changelog for #186
a5be240
@phil-opp
Copy link
Member

phil-opp commented Aug 9, 2021

Published as v0.10.7

@bjorn3 bjorn3 deleted the patch-1 branch August 9, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr josephlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjorn3 @phil-opp @josephlr