Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use set_reg method of CS, DS, ES and SS segment structs #211

Merged
merged 1 commit into from
Jan 9, 2022
Merged

use set_reg method of CS, DS, ES and SS segment structs #211

merged 1 commit into from
Jan 9, 2022

Conversation

abachmann
Copy link
Contributor

@abachmann abachmann commented Jan 9, 2022 •
edited
Loading

I switched to the set_reg method to set the SegmentSelector for CS, DS, ES and SS, because set_cs, load_ds, load_es and load_ss are deprecated in the x86_64 crate.

phil-opp
phil-opp approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phil-opp phil-opp merged commit 41833a6 into rust-osdev:main Jan 9, 2022
@abachmann abachmann deleted the deprecated_segmentation branch January 9, 2022 13:34
phil-opp added a commit that referenced this pull request Jan 9, 2022
@phil-opp
Update changelog for #210 and #211
7335ee9
@phil-opp
Copy link
Member

phil-opp commented Jan 9, 2022

Published together with #210 as v0.10.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abachmann @phil-opp