Skip to content

fix issue #315 #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

fix issue #315 #344

wants to merge 0 commits into from
+0 −0

Conversation

JarlEvanson
Copy link
Contributor

@JarlEvanson JarlEvanson commented Feb 16, 2023 •
edited
Loading

This pull request should close #315.

@phil-opp
Copy link
Member

Thanks a lot for tackling this! I saw that you also opened a PR on the uefi-rs repo to implement sorting the memory map: rust-osdev/uefi-rs#662. Given that this PR looks like it's closed to be merged, I wonder if it makes sense to wait for it instead of making our frame allocation more complex. What do you think?

@JarlEvanson
Copy link
Contributor Author

I think that it makes sense to wait, rather than introducing more complexity.

@phil-opp
Copy link
Member

Ok, thanks!

@phil-opp
Copy link
Member

I just merged #360 to update the UEFI dependency to v0.20. We should now be able to use the new sort function.

@JarlEvanson JarlEvanson deleted the issue-#315 branch April 16, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frame allocator assumes memory map is in ascending start address order
2 participants
@JarlEvanson @phil-opp