Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug stemming from treating an exclusive range as an inclusive r… #362

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Conversation

JarlEvanson
Copy link
Contributor

This should fix a rare bug regarding treating an exclusive range as an inclusive range when the zero_end is page aligned.

Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@phil-opp phil-opp merged commit bb92e9e into rust-osdev:main Apr 9, 2023
@phil-opp phil-opp mentioned this pull request Jul 5, 2023
phil-opp added a commit that referenced this pull request Feb 16, 2024
The `zero_end` bound is exclusive, but we treat the `end_page` as inclusive. So when `zero_end` is page-aligned, we allocate one additional bss page. If this page was already mapped to some other segment, we remap it to a page with random content.

This is the same bug as #362.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants