Ensure all page table frames are mapped as writable #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not quite sure that there's a bug here, so let's discuss this in #443 first. I'll convert this PR to a draft for now. |
Freax13
reviewed
May 24, 2024
|
@Wasabi375 This still needs to be addressed. |
|
Woops. Not sure how I missed your message. I changed those 2 places as well. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #443
This is a quick fix, for the issue above. That said I think this can still be improved for example we could use a
identity_map_with_table_flagsfunction in the x86 crate.Also as mentioned in the issue, maybe page table frames should be marked as
no_exec.