Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make MemoryMap own its buffer (Vec) #1204

Closed
DaniD3v opened this issue Jun 13, 2024 · 2 comments
Closed

make MemoryMap own its buffer (Vec) #1204

DaniD3v opened this issue Jun 13, 2024 · 2 comments

Comments

@DaniD3v
Copy link

DaniD3v commented Jun 13, 2024

To save your system Memory Map you need to call boot_services.memory_map_size() and allocate. I don't think doing this is possible without heap allocations? If that's the case why not just make MemoryMap own a vector, make memory_map_size() private (to increase usability) and remove the lifetime on MemoryMap?

I don't think there would be any downsides to doing that. I don't have a lot of experience in either UEFI or OSdev so feel free to correct me if I'm wrong

@nicholasbishop
Copy link
Member

You're in luck, there's a PR in progress to do exactly that: #1175

@DaniD3v DaniD3v closed this as completed Jun 13, 2024
@phip1611
Copy link
Member

phip1611 commented Jun 13, 2024

Yes, I'm working in that currently! I hope I can continue working on it in the next couple of days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants