-
-
Notifications
You must be signed in to change notification settings - Fork 169
Revert temporary revert #509 #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
2 tasks
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this issue
Sep 24, 2022
Add a CI job that runs `cargo xtask build` with an old nightly. Currently the oldest nightly that works is 2022-04-18. There's nothing particularly magic about that version; we can require a newer version when we deem it appropriate. Having this CI job just makes it easy for us to identify in advance when a PR is going to require a newer nightly, while still allowing other CI jobs to use latest nightly. This change is related to (but not a fix for): rust-osdev#510
2 tasks
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this issue
Sep 24, 2022
Add a CI job that runs `cargo xtask build` with an old nightly. Currently the oldest nightly that works is 2022-04-18. There's nothing particularly magic about that version; we can require a newer version when we deem it appropriate. Having this CI job just makes it easy for us to identify in advance when a PR is going to require a newer nightly, while still allowing other CI jobs to use latest nightly. This change is related to (but not a fix for): rust-osdev#510
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this issue
Sep 25, 2022
Add a CI job that runs `cargo xtask build` with an old nightly. Currently the oldest nightly that works is 2022-04-18. There's nothing particularly magic about that version; we can require a newer version when we deem it appropriate. Having this CI job just makes it easy for us to identify in advance when a PR is going to require a newer nightly, while still allowing other CI jobs to use latest nightly. This change is related to (but not a fix for): rust-osdev#510
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this issue
Sep 25, 2022
Add a CI job that runs `cargo xtask build` with an old nightly. Currently the oldest nightly that works is 2022-04-18. There's nothing particularly magic about that version; we can require a newer version when we deem it appropriate. Having this CI job just makes it easy for us to identify in advance when a PR is going to require a newer nightly, while still allowing other CI jobs to use latest nightly. This change is related to (but not a fix for): rust-osdev#510
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this issue
Sep 25, 2022
Add a CI job that runs `cargo xtask build` with an old nightly. Currently the oldest nightly that works is 2022-04-18. There's nothing particularly magic about that version; we can require a newer version when we deem it appropriate. Having this CI job just makes it easy for us to identify in advance when a PR is going to require a newer nightly, while still allowing other CI jobs to use latest nightly. This change is related to (but not a fix for): rust-osdev#510
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this issue
Sep 25, 2022
Add a CI job that runs `cargo xtask build` with an old nightly. Currently the oldest nightly that works is 2022-04-18. There's nothing particularly magic about that version; we can require a newer version when we deem it appropriate. Having this CI job just makes it easy for us to identify in advance when a PR is going to require a newer nightly, while still allowing other CI jobs to use latest nightly. This change is related to (but not a fix for): rust-osdev#510
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this issue
Sep 25, 2022
Add a CI job that runs `cargo xtask build` with an old nightly. Currently the oldest nightly that works is 2022-04-18. There's nothing particularly magic about that version; we can require a newer version when we deem it appropriate. Having this CI job just makes it easy for us to identify in advance when a PR is going to require a newer nightly, while still allowing other CI jobs to use latest nightly. This change is related to (but not a fix for): rust-osdev#510
nicholasbishop
added a commit
that referenced
this issue
Sep 25, 2022
Add a CI job that runs `cargo xtask build` with an old nightly. Currently the oldest nightly that works is 2022-04-18. There's nothing particularly magic about that version; we can require a newer version when we deem it appropriate. Having this CI job just makes it easy for us to identify in advance when a PR is going to require a newer nightly, while still allowing other CI jobs to use latest nightly. This change is related to (but not a fix for): #510
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #509 we temporarily reverted the
use
ofcore::ffi::CStr
as it is really new and we want to give the ecosystem a few more weeks/months time before we hardwire this into our crate.The text was updated successfully, but these errors were encountered: