Skip to content

Conversation

stillinbeta
Copy link
Contributor

@stillinbeta stillinbeta commented May 14, 2024

It took me most of an evening to figure this out, so I thought I'd share it!

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611
Copy link
Member

Sorry for the inconvenience you experienced. Great catch! I left some remarks.

@nicholasbishop I think we should expose all features except for unstable as default feature.

@nicholasbishop
Copy link
Member

@nicholasbishop I think we should expose all features except for unstable as default feature.

Sounds good to me.

@nicholasbishop nicholasbishop enabled auto-merge May 17, 2024 18:25
@nicholasbishop nicholasbishop added this pull request to the merge queue May 17, 2024
Merged via the queue into rust-osdev:main with commit 75ba438 May 17, 2024
@nicholasbishop
Copy link
Member

Merged, thanks for taking the time to document this :)

Filed a followup ticket to set default features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants