clippy: add use_self and const fn #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
clippy
branch
4 times, most recently
from
dc74b95 to
e49fb4f
Compare
phip1611
force-pushed
the
clippy
branch
2 times, most recently
from
70e1393 to
7164113
Compare
nicholasbishop
approved these changes
Jul 31, 2024
This has the benefit that users clearly see that no side effects can happen. However, the public API changes in the sense that once we remove const for a function, user code might break. Nevertheless, this is a code improvement, IMHO. Regarding the device path code, which is generated: So far the simplest solution is to deactivate this lint there. It is not trivial to decide which function can be const and which not during code generation. It is future work to solve this, if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #546, which adds
constto more functions, adds it as mandatory lint, and also usesSelfwhere possible.Checklist