Skip to content

uefi: Fix lifetimes in device_path TryFrom<&[u8]> impls #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024
Merged

uefi: Fix lifetimes in device_path TryFrom<&[u8]> impls #1282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions uefi/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@
> use uefi::table::boot::BootServices;
```


# uefi - 0.30.0 (unreleased)
## Changed
- **Breaking:**: Fixed a bug in the impls of `TryFrom<&[u8]>` for
`&DevicePathHeader`, `&DevicePathNode` and `&DevicePath` that could lead to
memory unsafety. See <https://github.com/rust-osdev/uefi-rs/issues/1281>.


# uefi - 0.29.0 (2024-07-02)

## Added
Expand Down
6 changes: 3 additions & 3 deletions uefi/src/proto/device_path/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ pub struct DevicePathHeader {
pub length: u16,
}

impl<'a> TryFrom<&[u8]> for &'a DevicePathHeader {
impl<'a> TryFrom<&'a [u8]> for &'a DevicePathHeader {
type Error = ByteConversionError;

fn try_from(bytes: &[u8]) -> Result<Self, Self::Error> {
Expand Down Expand Up @@ -265,7 +265,7 @@ impl PartialEq for DevicePathNode {
}
}

impl<'a> TryFrom<&[u8]> for &'a DevicePathNode {
impl<'a> TryFrom<&'a [u8]> for &'a DevicePathNode {
type Error = ByteConversionError;

fn try_from(bytes: &[u8]) -> Result<Self, Self::Error> {
Expand Down Expand Up @@ -516,7 +516,7 @@ impl PartialEq for DevicePath {
}
}

impl<'a> TryFrom<&[u8]> for &'a DevicePath {
impl<'a> TryFrom<&'a [u8]> for &'a DevicePath {
type Error = ByteConversionError;

fn try_from(bytes: &[u8]) -> Result<Self, Self::Error> {
Expand Down