ci: release package check #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/release.yml
Outdated
| # Checks if `cargo package` can run successfully. This saves us from | ||
| # situations where this is only noticed after a merge and releases | ||
| # were made only partially. | ||
| run: cargo package |
There was a problem hiding this comment.
Does this work without package args? I get a failure in the uefi_app package when I run cargo package locally. cargo package -p uefi -p uefi-raw -p uefi-macros works, however
There was a problem hiding this comment.
I think it is fine to directly list the crates
This way, we can early spot issues before they occur in unfortunate situations, as happened with [0]. [0] rust-osdev#1338
nicholasbishop
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to prevent situations as documented in #1338
Checklist