Fix clippy::needless_lifetimes in Rust 1.83 and ShimLock ABI on ia32 #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was sysv64. As of Rust 1.83, this is rejected by the compiler as incompatible with an i386 target.
nicholasbishop
changed the title
|
I'm not 100% sure that cdecl is what we want for ShimLock on ia32; the Rust docs are rather sparse, and shim doesn't document the protocol's ABI at all. But it at least compiles, which is better than sysv64. |
2 tasks
|
Merging to unblock CI |
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist