test-runner: Clean up device path tests #1527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the conversion tests out into separate functions. This is a bit more verbose, but makes it clearer exactly what is being tested. The conversion tests now use a hardcoded test `DevicePath`, so we no longer need to `cfg` the tests for different arches based on what devices QEMU creates. This also makes it clearer what effects `DisplayOnly` and `AllowShortcuts` can have on the text conversion.
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the conversion tests out into separate functions. This is a bit more verbose, but makes it clearer exactly what is being tested.
The conversion tests now use a hardcoded test
DevicePath, so we no longer need tocfgthe tests for different arches based on what devices QEMU creates. This also makes it clearer what effectsDisplayOnlyandAllowShortcutscan have on the text conversion.Checklist