add ip4config2 + http protocols support #1614
Conversation
There was a problem hiding this comment.
Thanks for your contribution, looks good! I left a few remarks.
Further, before this can be merged: Please add a integration test to uefi-test-runner similar to our other protocol tests. To prevent flakiness, I'd say you try to get a HTTP Response from any of [google.com, example.com, amazon.com] and if any responds positive, the test succeeds.
I think we need a network device for the integration test. Not sure if we have one at the moment. Feel ree to reach out in case you need guidance.
Hmm, I guess that calls for bringing in https://gitlab.com/kraxel/virt-firmware-rs/-/blob/main/efi-apps/src/net/ip4config2.rs first. That probably needs a few more refinements though, right now it simply uses
What is used for the tests? qemu I guess? |
draft: #1615 |
You can run the integration tests using Here you can find an example for how a protocol integration test was added: |
kraxel
changed the title
| status_code: HttpStatusCode::STATUS_UNSUPPORTED, | ||
| }; | ||
|
|
||
| let mut body = vec![0; if expect_body { 16 * 1024 } else { 0 }]; |
There was a problem hiding this comment.
16 * 1024? Where do these numbers come from?
There was a problem hiding this comment.
16k buffer for the body. Figured by experimenting a bit. I havn't seen the uefi protocol return more in one call. Often it is much less though, between 1000 + 1500 (payload of one ethernet frame?).
|
|
||
| // hard to find web sites which still allow plain http these days ... | ||
| info!("Testing HTTP"); | ||
| let Some(_) = fetch_http(*h, "http://boot.netboot.xyz/robots.txt") else { |
There was a problem hiding this comment.
How about http://example.com? (And https://example.com for below)
There was a problem hiding this comment.
Oh, didn't now example.com actually exists.
Problem is that https connections to example.com do not work with current ovmf builds.
tianocore/edk2#10962
There was a problem hiding this comment.
Until ovmf works with https://example.com, how about example.com for http, and github.com for https? If github.com was inaccessible then CI probably wouldn't work anyway, so it seems like an OK website to rely on.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This is needed for https support (tls server certificate verification). Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
Ok, works locally but fails in CI, apparently the prebuilt binaries do not have TLS support included |
temporary stopgap, can be reverted once the prebuilt ovmf binarties have https support included. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
The prebuilt OVMF files, you mean? I think we can fix that quite easily, can't we? @nicholasbishop |
This adds http protocol support.
Usage example: see
fn fetch_httpin https://gitlab.com/kraxel/virt-firmware-rs/-/blob/main/efi-apps/src/bin/netboot.rs