uefi-raw and uefi: use core::net types where possible, remove duplicated types
#1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
changed the title
core::net types where possible, remove duplicated types
phip1611
force-pushed
the
core-net
branch
2 times, most recently
from
0b3a947 to
8543063
Compare
This simplifies things as we have less types to work with. The overall convenience is improved and people will be less confused with the automated imports suggested by their IDE. As the core::Net types are ABI compatible, and it is unlikely that they will ever change in core, we should go for this simplification.
phip1611
force-pushed
the
core-net
branch
2 times, most recently
from
728dc3b to
6291e95
Compare
|
I personally see this as a major step forward. On the other hand, I'm biased 😁 I'm looking forward to the discussion and other's ideas! |
This tightly integrates the type with the Rust standard IpAddr type. It allows the convenient usage in `uefi` in a later commit.
This does not use core::net::IpAddr in all possible public interfaces. Although there is opportunity for that, this commit only makes `uefi` compatible with the new `uefi-raw` type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to bring the discussion of #1575 one step further. It outlines my vision on how we could simplify the interface.
I removed all dedicated types except for
uefi-rawsIpAddress. This type is now tightly integrated withcore::net::{IpAddr, Ipv4Addr, Ipv6Addr}. I think this is a major step forward in convenience and usability.Please review this commit-by-commit.
Steps to Undraft
-> then we can have a better debug impl
Checklist