Skip to content

Fix function ABI #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2018
Merged

Fix function ABI #39

merged 2 commits into from
Sep 24, 2018

Conversation

GabrielMajeri
Copy link
Collaborator

@GabrielMajeri GabrielMajeri commented Sep 24, 2018 •
edited
Loading

This PR replaces the extern "C" ABI with extern "win64". This ensures that an ELF kernel can safely call the functions in this crate, but we drop support for 32-bit.

Temporary solution for #38

@GabrielMajeri GabrielMajeri changed the title Fix ABI Fix function ABI Sep 24, 2018
HadrienG2
HadrienG2 approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@HadrienG2 HadrienG2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would need something like the EFIAPI define to do this cleanly. Not sure how easy it is to implement something like this with Rust's macro system, but it would be useful for some other things that I have in mind.

@HadrienG2 HadrienG2 merged commit f525b86 into master Sep 24, 2018
@GabrielMajeri GabrielMajeri deleted the 64-bit branch September 24, 2018 08:40
@HadrienG2 HadrienG2 mentioned this pull request Sep 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HadrienG2 HadrienG2 HadrienG2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabrielMajeri @HadrienG2